fix(span_processor): only call on_start with recording spans#3011
Merged
cijothomas merged 2 commits intoMay 30, 2025
Merged
Conversation
According to the spec, spans that are not recording should not be passed to span processors.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3011 +/- ##
=====================================
Coverage 81.0% 81.0%
=====================================
Files 126 126
Lines 24753 24755 +2
=====================================
+ Hits 20070 20072 +2
Misses 4683 4683 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bantonsson
approved these changes
May 30, 2025
cijothomas
approved these changes
May 30, 2025
takumi-earth
pushed a commit
to earthlings-dev/opentelemetry-rust
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
SpanProcessor API refactor #2940
Changes
According to the spec, spans that are not recording should not be passed to span processors.
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#recording-sampled-reaction-table
This PR fixes this interaction.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes